spring-projects / spring-projects/spring-security

DelegatingSecurityContextExecutorService cannot be extended

Open
#5,047 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: waiting-for-triage
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

Summary

I would like to use a PriorityBlockingQueue but also need access to the security context. The current implementation will not allow me to wrap the callable/runnable in a class that can implement comparable OR use a comparator that can see the wrapped class and make a sorting decision.

The wrapper is static and all classes and methods are marked final. I would like to be able to extend the class(es) that implement this delegate pattern to introduce a custom wrapper that can be sorted.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with DelegatingSecurityContextExecutorService and the related delegate-pattern classes described in the issue; inspect how their static wrappers and final classes or methods prevent extension. The work is done when a custom wrapper can be introduced for sorting in a PriorityBlockingQueue while preserving access to the security context, with tests covering that use case.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.