spring-projects / spring-projects/spring-security

SampleWebSecurityConfigurerAdapterTests -> use MockMvc

Open
#5,032 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

in: test type: enhancement
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

SampleWebSecurityConfigurerAdapterTests currently uses MockHttpServletRequest, MockHttpServletResponse and MockFilterChain directly in the test.

We should change the test to use MockMvc instead as this removes much of the setup/boilerplate code.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the SampleWebSecurityConfigurerAdapterTests test and review its direct use of MockHttpServletRequest, MockHttpServletResponse, and MockFilterChain. Replace that setup with MockMvc while preserving the test behavior, then run the focused test to verify it passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
testing
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.