spring-projects / spring-projects/spring-security
Minor improvement for JdbcTokenRepositoryImpl
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Summary
Hello, I have faced an issue that I cannot get named parameter JDBC template while I work with your implementation (org.springframework.security.web.authentication.rememberme.JdbcTokenRepositoryImpl). I my current case I need to create my own implementation of repository instead of extending yours, which is not difficult, but odd in some case.
Version
It affects all versions of Spring Security.
Sample
As I see, all that needs to be done is to replace interface.
Current version:
public class JdbcTokenRepositoryImpl extends JdbcDaoSupport implements PersistentTokenRepository {
What I propose:
public class JdbcTokenRepositoryImpl extends NamedParameterJdbcDaoSupport implements PersistentTokenRepository {
Thanks.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with org.springframework.security.web.authentication.rememberme.JdbcTokenRepositoryImpl and inspect how its JDBC support is used. Check the surrounding remember-me repository tests or entry points, then verify that extending the named-parameter JDBC support allows subclasses to access it without changing existing token repository behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 62/100