spring-projects / spring-projects/spring-security
InternalAuthenticationServiceException is not mapped by DefaultAuthenticationEventPublisher
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
The DefaultAuthenticationEventPublisher.publishAuthenticationFailure() method handles AuthenticationServiceException well, but not InternalAuthenticationServiceException (it does not creates an event for it)
(I guess there should be an addMapping() call in the DefaultAuthenticationEventPublisher's constructor for InternalAuthenticationServiceException as well)
Actual Behavior
No event published.
Expected Behavior
I'd expect the same (or similar behaviour) like for an AuthenticationServiceException.
Version
Spring Boot 2.0.0 M1 (using all the default versions)
Spring Security 5.0.0 M1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in DefaultAuthenticationEventPublisher.publishAuthenticationFailure() and its constructor, comparing the existing AuthenticationServiceException handling with InternalAuthenticationServiceException. Verify the no-event case and confirm that the latter produces the same or equivalent authentication event behavior as the former.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100