spring-projects / spring-projects/spring-security
AbstractRememberMeServices does not erase Credentials as ProviderManager do
Open
Nobody has claimed this yet.
status: waiting-for-triage
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
AbstractRememberMeServices does not erase Credentials as ProviderManager do after successful authentication. Although this behavior can be done by customizing the onSuccessfulAuthentication of RememberMeAuthenticationFilter, hope the default erase action can be added so that the RememberMe authentication flow is consistent with normal authentication flow serviced by ProviderManager .
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading AbstractRememberMeServices and comparing its successful-authentication behavior with ProviderManager's credential-erasure behavior. Check the RememberMeAuthenticationFilter flow and add or adjust coverage for successful remember-me authentication; done means credentials are erased by default without customization.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100