spring-projects / spring-projects/spring-security
s:mvcUrl builds wrong URL with Spring Security and DispatcherServlet mapped to subfolder
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Summary
When using Spring Security the JSP taglib function s:mvcUrl produces wrong URLs. This happens only when the request is served by a DispatcherServlet that is not mapped to the root folder, but to a subfolder (e.g. <url-pattern>/backend/*</url-pattern> instead of <url-pattern>/*</url-pattern>).
Actual Behavior
Suppose that in web.xml a DispatcherServlet is configured as follows:
<servlet>
<servlet-name>backend-web</servlet-name>
<servlet-class>org.springframework.web.servlet.DispatcherServlet</servlet-class>
<init-param>
<param-name>contextConfigLocation</param-name>
<param-value>WEB-INF/backend-web-context.xml</param-value>
</init-param>
<load-on-startup>1</load-on-startup>
</servlet>
<servlet-mapping>
<servlet-name>backend-web</servlet-name>
<url-pattern>/backend/*</url-pattern>
</servlet-mapping>
and that Spring Security's filter chain is configured as follows:
<filter>
<filter-name>springSecurityFilterChain</filter-name>
<filter-class>org.springframework.web.filter.DelegatingFilterProxy</filter-class>
</filter>
<filter-mapping>
<filter-name>springSecurityFilterChain</filter-name>
<url-pattern>/*</url-pattern>
</filter-mapping>
Suppose also that there's a simple controller like the following one:
@Controller
@RequestMapping(path="/hello", name="HelloCtl")
public class HelloController {
@RequestMapping(path="/random", method=RequestMethod.GET, name="random")
public String randomHello(Model model){
...
}
}
If in a JSP the following function is called, the URL produced is wrong:
${s:mvcUrl('HelloCtl#random')} --> output is /hello/random
Expected Behavior
In the above scenario the call to s:mvcUrl() should produce /backend/hello/random. The base path given by the mapping of the DispatcherServlet is missing (/backend).
This happens only when Spring Security is enabled. Otherwise the URL is built properly.
Configuration
This issue should affect configurations in which there's a DispatcherServlet mapped to url pattern which is a non-root path. In particular configuration with multiple web contexts.
Version
The problem occurs with Spring 4.3.6 and Spring Security 4.2.1. I've not tried older versions. Consider that s:mvcUrl exists only since Spring 4.2.
Sample
The attached ZIP includes a Maven sample application that reproduces the problem. You can see that the problem is solved if the Spring Security is disabled by removing the filter chain configuration from web.xml.
To see the problem, point the browser the URL /backend/hello/random. The rendered JSP uses s:mvcUrl() to print out the URL pointing to HelloController#randomHello(), which is the action that renders the JSP itself. You should see that it's not correct. Credentials are: username: user / password: password.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the web.xml servlet and filter mappings in the attached Maven sample, then trace the JSP s:mvcUrl('HelloCtl#random') call for the /backend/hello/random request. Compare URL generation with Spring Security enabled and disabled; done means the generated URL includes the /backend servlet mapping while preserving the existing behavior without security.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100