spring-projects / spring-projects/spring-security

Expose framework created SessionAuthenticationStrategy

Open
#3,995 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: waiting-for-triage
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

Summary

In scenarios where a custom AbstractAuthenticationProcessingFilter is created using XML configuration, it would be interesting to inject the SessionAuthenticationStrategy instance already created and wired by framework instead of creating our own or having to use some workarounds to get it.

Actual Behavior

SessionAuthenticationStrategy created by the framework is not exposed to be used by other beans.

Expected Behavior

Expose the framework created SessionAuthenticationStrategy as an aliased bean, similarly to AuthenticationManager (via <security:authentication-manager>).

Configuration
<bean id="usernamePasswordAuthenticationFilter"
     class=" o.s.scurity.web.authentication.UsernamePasswordAuthenticationFilter">

    <property name="sessionAuthenticationStrategy">
        <!-- Workaround to get hold of the framework created SessionAuthenticationStrategy -->
        <ref bean="org.springframework.security.web.authentication.session.CompositeSessionAuthenticationStrategy#0"/>                
    </property>
 </bean>
Version

4.1.1 (probably applicable to previous versions)

Sample

http://stackoverflow.com/questions/26429967/how-to-get-a-reference-to-sessionauthenticationstrategy-without-configuring-the

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the XML security configuration that creates the framework's SessionAuthenticationStrategy and compare its bean exposure with the AuthenticationManager configuration. The work is done when that existing strategy is available to other beans through an aliased bean without requiring the documented workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
authentication
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.