spring-projects / spring-projects/spring-security
Expose framework created SessionAuthenticationStrategy
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Summary
In scenarios where a custom AbstractAuthenticationProcessingFilter is created using XML configuration, it would be interesting to inject the SessionAuthenticationStrategy instance already created and wired by framework instead of creating our own or having to use some workarounds to get it.
Actual Behavior
SessionAuthenticationStrategy created by the framework is not exposed to be used by other beans.
Expected Behavior
Expose the framework created SessionAuthenticationStrategy as an aliased bean, similarly to AuthenticationManager (via <security:authentication-manager>).
Configuration
<bean id="usernamePasswordAuthenticationFilter"
class=" o.s.scurity.web.authentication.UsernamePasswordAuthenticationFilter">
<property name="sessionAuthenticationStrategy">
<!-- Workaround to get hold of the framework created SessionAuthenticationStrategy -->
<ref bean="org.springframework.security.web.authentication.session.CompositeSessionAuthenticationStrategy#0"/>
</property>
</bean>
Version
4.1.1 (probably applicable to previous versions)
Sample
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the XML security configuration that creates the framework's SessionAuthenticationStrategy and compare its bean exposure with the AuthenticationManager configuration. The work is done when that existing strategy is available to other beans through an aliased bean without requiring the documented workaround.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100