spring-projects / spring-projects/spring-security
Extract Cookie writing logic into WebUtils
Open
Nobody has claimed this yet.
in: web
type: enhancement
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Cookie writing logic is currently duplicated in the following classes:
AbstractRememberMeServices
CookieCsrfTokenRepository
CookieClearingLogoutHandler
Extract common logic into WebUtils to allow for reuse.
WebUtils seems like the most logical option given that logic for reading Cookies is housed here as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the cookie-writing logic in AbstractRememberMeServices, CookieCsrfTokenRepository, and CookieClearingLogoutHandler with the cookie-reading logic in WebUtils. Done means the common writing logic is available from WebUtils and the three named classes reuse it without duplicating that logic.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- security
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100