spring-projects / spring-projects/spring-security
Make classes DefaultPreAuthenticationChecks and DefaultPostAuthenticationChecks public
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Can DefaultPreAuthenticationChecks and DefaultPostAuthenticationChecks (in AbstractUserDetailsAuthenticationProvider) be changed to public (from private)?
It would be useful to extend those classes...
...to append some additional checks to the default checks.
...and avoid copying the default checks code to a custom implementation
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with AbstractUserDetailsAuthenticationProvider and locate DefaultPreAuthenticationChecks and DefaultPostAuthenticationChecks. Confirm that both classes can be extended externally without copying the default checks, and add or update coverage for the visibility change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- authentication, security
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100