spring-projects / spring-projects/spring-security

SEC-3015: Better handling for ldap PASSWORD_NEEDS_RESET error code

Open
#3,225 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: enhancement type: jira
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

Ben Kiefer (Migrated from SEC-3015) said:

Is there any way we can get a new exception bubbled out of the ActiveDirectoryLdapAuthenticationProvider for this, or even map it to the CredentialsExpiredException or an extension of this exception?

Right now, it ends up leaving as a BadCredentialsException, and then I need to parse that exception and do the same routing as the CredentialsExpiredException.

Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with ActiveDirectoryLdapAuthenticationProvider and trace how the LDAP PASSWORD_NEEDS_RESET code becomes a BadCredentialsException. Compare the requested CredentialsExpiredException or extension behavior; done means callers no longer need to parse BadCredentialsException for this condition.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
authentication, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.