spring-projects / spring-projects/spring-security
SEC-2796: Principal of Servlet Api RequestWrappers
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
cemo koc (Migrated from SEC-2796) said:
Servlet Api Configured HttpServletWrappers currently returns Authentication for org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestWrapper#getUserPrincipal.
I think that If org.springframework.security.core.Authentication#getPrincipal is a java.security.Principal, It is better to return it.
We have considered this before, but because of being a breaking change we have postponed this issue for Spring Security 4. It would be nice to address this issue as well.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at SecurityContextHolderAwareRequestWrapper#getUserPrincipal and compare its current return value with Authentication#getPrincipal. Confirm how the Servlet API wrapper handles a principal implementing java.security.Principal, then update the behavior while accounting for the noted breaking-change concern. Done means the wrapper returns that principal when applicable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100