spring-projects / spring-projects/spring-security
SEC-2763: Make JdbcUserDetailsManager extensible
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Mauro Molinari (Migrated from SEC-2763) said:
JdbcUserDetailsManager is not easily extensible:
- query strings are private and there are no getter methods
insertUserAuthorities(UserDetails)anddeleteUserAuthorities(String)are privateuserCacheis private and there is no getter method- other useful methods like
validateUserDetails(UserDetails)andvalidateAuthorities(Collection<? extends GrantedAuthority>)are also private...
This is in contrast with JdbcDaoImpl whose design is much better from this point of view, except for org.springframework.security.core.userdetails.jdbc.JdbcDaoImpl.groupAuthoritiesByUsernameQuery which also misses a getter method.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading JdbcUserDetailsManager and comparing its listed private query strings, userCache, and authority/validation methods with JdbcDaoImpl. Define the extensibility surface requested in the issue and verify that existing JDBC user-management behavior remains intact; no test or file path is named.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- databases, security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100