spring-projects / spring-projects/spring-security
SEC-2844: Clarify reference guide in relation to AfterInvocationManager
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Jordi Llach Fernandez (Migrated from SEC-2844) said:
I think that user reference should make much clearer to the reader that FilterSecurityInterceptor would call AfterInvocationManager but this won't be able to modify the response. In fact this is very reasonable but I think that a mention about the different uses of AfterInvocationManager when 'decorating' a FilterSecurityInterceptor or MethodSecurityInterceptor would be valuable.
Refs from the guides :
http://docs.spring.io/spring-security/site/docs/3.2.5.RELEASE/reference/htmlsingle/#secure-objects
http://docs.spring.io/spring-security/site/docs/3.2.5.RELEASE/reference/htmlsingle/#afterinvocationmanager
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the secure-objects and afterinvocationmanager sections linked in the issue's Spring Security reference guides. Clarify how FilterSecurityInterceptor and MethodSecurityInterceptor use AfterInvocationManager, including the response-modification distinction. Done means the reference guide clearly explains these different behaviors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- documentation, security
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100