spring-projects / spring-projects/spring-security

SEC-2722: CsrfToken invalidated when using PreAuthenticatedProcessingFilter with checkForPrincipalChanges enabled

Open
#2,947 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

in: web type: bug type: jira
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

Michael Russo (Migrated from SEC-2722) said:

The issue stems CsrfFilter being called before PreAuthenticatedProcessingFilter in the security filter chain. CsrfFilter will detect that a token exists for the (currently valid) session, but the PreAuthenticatedProcessingFilter invalidates the session later in the chain, so a new token won't be generated for the remainder of this request.

This issue is resolved if the PreAuthenticatedProcessingFilter is added before the CsrfFilter in the chain. Then, session invalidation occurs first, so CsrfFilter will correctly generate a new token for this request.

As a side-note, when this situation occurs, the request attribute "_csrf" won't match the session attribute (which was erased), so any view that relies on the request attribute will see an invalid token instead of an empty one. This is because CsrfFilter sets the request attribute immediately and delays adding the session attribute due to SEC-2276

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing CsrfFilter and PreAuthenticatedProcessingFilter in the security filter chain, focusing on session invalidation, request attributes, and delayed session-token storage described in the issue. Done should ensure that enabling checkForPrincipalChanges does not leave the request with a token from an invalidated session, while preserving the stated filter-order behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
authentication, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.