spring-projects / spring-projects/spring-security

SEC-2666: trustResolver and DefaultMethodSecurityExpressionHandler

Open
#2,886 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: enhancement type: jira
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

le roy arnaud (Migrated from SEC-2666) said:

Hi,

what do you think about change the private attribute to the variable
trustResolver into the DefaultMethodSecurityExpressionHandler ?

i think it could be fine to change to protected, for developers that want create a custom securityExpressionHandler and pass it directly to the methodsecurityexpression.

because if you don't set it (trustResolver), you can't use this kind of expression :

@PreAuthorize("isAuthenticated()")

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate DefaultMethodSecurityExpressionHandler and inspect how its private trustResolver is initialized and used by the isAuthenticated() expression. Check the surrounding method-security tests or entry points, then verify that a custom expression handler can configure the resolver and that the expression continues to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
authorization, security
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.