spring-projects / spring-projects/spring-security

SEC-2611: Spring Security Config's OSGi manifest requires LDAP

Open
#2,827 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

in: config type: bug type: jira
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

Olafur Egilsson (Migrated from SEC-2611) said:

When I import Spring Security's Config bundle in my Karaf (3.0.1) OSGi server, I get an error saying that Spring Security LDAP isn't avaialble:
Error executing command: Could not start bundle mvn:org.springframework.security/spring-security-config/3.2.3.RELEASE in feature(s) mm-0.0.0: Unresolved constraint in bundle org.springframework.security.config [172]: Unable to resolve 172.0: missing requirement [172.0] osgi.wiring.package; (&(osgi.wiring.package=org.springframework.security.ldap)(version>=3.2.3.RELEASE)(!(version>=3.3.0)))

However, I don't need LDAP for my purposes. When I start adding LDAP depencency chain, a whole bunch of bundles are required: spring-security-ldap, spring-ldap, spring-batch.

In the end, Spring LDAP requires a package which doesn't seem to be available: (&(osgi.wiring.package=org.springframework.batch.item.file) version>=2.0.0)(!(version>=3.0.0)))

Could we make the LDAP dependency optional in the Manifest?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Spring Security Config bundle's OSGi manifest and inspect why it imports org.springframework.security.ldap as a required package. Reproduce the bundle resolution failure in the reported Karaf setup, then verify that Config can resolve without LDAP while preserving LDAP support when its dependencies are present.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
backend, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.