spring-projects / spring-projects/spring-security
SEC-2530: BasicAuthenticationFilter does not respect charset encoding
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Alexey Grigoryev (Migrated from SEC-2530) said:
BasicAuthenticationFilter has hard coded char set UTF-8.
But according to RFC2616, RFC2617 it should be iso-8859-1 or detected with mime format which does not happen too.
Please see discussion: http://stackoverflow.com/questions/7242316/what-encoding-should-i-use-for-http-basic-authentication
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating BasicAuthenticationFilter and inspect where its Basic Authentication credentials are decoded. Read the referenced RFC2616 and RFC2617 guidance and the linked discussion, then determine the expected charset behavior; done means the filter no longer unconditionally uses UTF-8 and has regression coverage for the agreed behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- authentication, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100