spring-projects / spring-projects/spring-security
SEC-2429: key in TokenBasedRememberMeServices and RememberMeAuthenticationProvider should be synced
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Jason Jiang (Migrated from SEC-2429) said:
When I use the namespace to configure spring context for RememberMe, I was confused that it didn't work. After debugging into it, i found my configuration is incorrect but no useful information logged.
The configuration below make the RememberMeAuthenticationProvider and TokenBasedRememberMeServices un-synced. I was trying to fix it and provide a patch. But I am not sure whether override or just warning messages is better. So I will leave it for you guys.
<beans:bean id="rememberMeServices" class="org.springframework.security.web.authentication.rememberme.TokenBasedRememberMeServices">
<beans:constructor-arg name="key" value="new_app_key" />
<beans:constructor-arg name="userDetailsService" ref="userService" />/beans:property
/beans:bean
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading TokenBasedRememberMeServices and RememberMeAuthenticationProvider, then trace how the namespace configuration wires the remember-me key. Compare the shown services-ref configuration with the provider setup and determine the expected behavior when the keys differ. Done should include a clear, tested decision on synchronization or diagnostic reporting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100