spring-projects / spring-projects/spring-security
SEC-2403: CsrfFilter and CsrfRequestDataValueProcessor is not consistent on policy of injection.
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Kazuki Shimizu (Migrated from SEC-2403) said:
I think so that CsrfFileter and CsrfRequestDataValueProcessor is not consistent on policy of injection.
Reasons is following:
CsrfFileter is able to inject the http method of processing target. But, CsrfRequestDataValueProcessor is not able to inject the http method of processing target. Http method of processing target is fixed in private constants.
I think so that should be use same strategy for determine the http method of processing target.
What do you think ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading CsrfFilter and CsrfRequestDataValueProcessor to compare how each determines the HTTP method for CSRF processing. Trace the existing injection behavior and its tests, then define completion as both components applying the same method-selection policy.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100