spring-projects / spring-projects/spring-security
SEC-2389: DigestAuthenticationFilter doesn't call RememberMeServices
Open
Nobody has claimed this yet.
type: enhancement
type: jira
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
LAMARE Jean-Marie (Migrated from SEC-2389) said:
Contrary to BasicAuthenticationFilter, the methods RememberMeServices.loginSuccess and RememberMeServices.loginFail cannot be called from the filter DigestAuthenticationFilter.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing DigestAuthenticationFilter with BasicAuthenticationFilter and inspect how RememberMeServices is used in each filter. Determine the expected loginSuccess and loginFail behavior from those existing paths; done means DigestAuthenticationFilter invokes the appropriate RememberMeServices methods consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100