spring-projects / spring-projects/spring-security
SEC-2351: Sub classes of UsernamePasswordAuthenticationFilter can't read postOnly attribute
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Gregor Koukkoullis (Migrated from SEC-2351) said:
When creating a sub class of UsernamePasswordAuthenticationFilter for example to override attemptAuthentication(HttpServletRequest, HttpServletResponse) the sub class can't access the postOnly attribute to implement the same check as in UsernamePasswordAuthenticationFilter.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating UsernamePasswordAuthenticationFilter and read its attemptAuthentication(HttpServletRequest, HttpServletResponse) implementation, focusing on how postOnly is declared and checked. Confirm that a subclass overriding the method cannot access the attribute, then verify the resulting API allows the subclass to perform the same check without changing the intended authentication behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication, backend, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100