spring-projects / spring-projects/spring-security
SEC-2225: Concurrency Control Refactor
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Rob Winch (Migrated from SEC-2225) said:
Right now concurrency control is tied to HttpSession. This means for authentication with a custom AuthenticationRegistry it does not work.
It also does not work with Http Basic. What does this mean though? Would we ever want to restrict the concurrent users with Http Basic? How would we know when it was a new user or an old user since we always authenticate?
We need to look into all the types of authentication and ensure concurrency control plays nicely with it. For example, remember me does not work with concurrency control SEC-2028
Additionally, ideally Concurrency Control would not be a polling mechanism (e.g. for every request check if session was expired). Instead, it would ideally call an endpoint to invalidate the session.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by mapping the existing concurrency-control entry points across HttpSession, custom AuthenticationRegistry, HTTP Basic, and remember-me flows; define expected behavior for each authentication type and a session-invalidation endpoint before implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication, security
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100