spring-projects / spring-projects/spring-security
SEC-2188: Change CasAuthenticationProvider authenticateNow() method to protected
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
James Lorenzen (Migrated from SEC-2188) said:
I'm trying to enhance CasAuthenticationProvider to add some additional features. Specifically I'd like to override the authenticateNow() method, but it's private and consequently I have to override the authenticate() method as well, which is redundant.
Can you please make the authenticateNow() method protected so one can override it's functionality?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search for CasAuthenticationProvider and its authenticateNow() method, then read how authenticate() uses it. Inspect any existing authentication tests if available. Done means authenticateNow() is protected, subclasses can override it without overriding authenticate(), and existing authentication behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- authentication, security
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100