spring-projects / spring-projects/spring-security
SEC-2152: OpenIDAuthenticationFilter errors are "lost" if logging > debug
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Daniel Serodio (Migrated from SEC-2152) said:
I'm using OpenIDAuthenticationFilter, and when I have an authentication error (in my case, most often caused by SSL problems), the error doesn't appear anywhere unless I set org.springframework.security.openid logging to DEBUG.
In the catch block at OpenIDAuthenticationFilter.java:132, this error should be logged as INFO, or at least, the re-thrown exception (AuthenticationServiceException) should wrap the caught exception.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in openid/src/main/java/org/springframework/security/openid/OpenIDAuthenticationFilter.java at the catch block around line 132. Trace how the caught authentication error is logged and how AuthenticationServiceException is re-thrown. Done means the error is surfaced at the requested logging level or preserved through the re-thrown exception.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100