spring-projects / spring-projects/spring-security
SEC-2120: Include exception message in logs for IllegalStateException in HttpSessionSecurityContextRepository.SaveToSessionResponseWrapper.createNewSessionIfAllowed()
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
alt250 (Migrated from SEC-2120) said:
IllegalStateException exception message should be logged to allow finding the root cause of hard-to-reproduce issues with session creation in this context.
The reason being that "response has been committed" is not the only possible cause.
Stack trace can also be logged in debug mode.
try {
return request.getSession(true);
} catch (IllegalStateException e) {
// Response must already be committed, therefore can't create a new session
logger.warn("Failed to create a session, as response has been committed. Unable to store SecurityContext."); <<< add more information here
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in HttpSessionSecurityContextRepository.SaveToSessionResponseWrapper.createNewSessionIfAllowed() and inspect the catch block shown in the issue. Review nearby logging and related tests, then verify that the IllegalStateException message and optional debug stack trace are logged without changing session-creation behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100