spring-projects / spring-projects/spring-security
SEC-2112: ExceptionMappingAuthenticationFailureHandler does not forward to failure destination
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Max Englander (Migrated from SEC-2112) said:
ExceptionMappingAuthenticationFailureHandler does not forward to the destination failure url if it is configure to do so with setUseForward.
The documentation for ExceptionMappingAuthenticationFailureHandler does not specify whether it will forward to to destination failure url if it is configured to do so.
I think, given that it inherits from SimpleUrlAuthenticationFailureHandler (which does forward if configured to do so), either it ought to forward as well, or else the documentation should specify that it will not.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ExceptionMappingAuthenticationFailureHandler and its SimpleUrlAuthenticationFailureHandler parent, focusing on setUseForward and the failure destination behavior described in the issue. Check the linked API documentation for the documented contract. Done means the handler either forwards consistently with its parent or clearly documents that it does not.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100