spring-projects / spring-projects/spring-security
SEC-2044: Create AuthenticationFactory
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Rob Winch (Migrated from SEC-2044) said:
Currently if a user wants to support an additional parameter for an existing type of Authentication, they need to implement or extend the Filter that creates the Authentication and passes it to the AuthenticationManager. It would be nice if it could accept a strategy for creating the Authentication to limit the changes required for additional parameters. For example, instead of extending the UsernamePasswordAuthenticationFilter to support multi tenants with a tenant identifier, one could implement the AuthenticationFactory which would create a TenantUsernamePasswordAuthenticationToken.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by examining the authentication filters that create Authentication objects, especially UsernamePasswordAuthenticationFilter, and how they pass them to AuthenticationManager. The work is complete when an AuthenticationFactory strategy can create a type such as TenantUsernamePasswordAuthenticationToken without requiring users to extend the filter.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- authentication, security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100