spring-projects / spring-projects/spring-security
SEC-1966: LdapServerBeanDefinitionParser is making decision based on unresolved value of url attribute
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Ritesh (Migrated from SEC-1966) said:
Please see http://stackoverflow.com/questions/10483032/spring-property-file-empty-values and its accepted answer. LdapServerBeanDefinitionParser is calling createEmbeddedServer based on unresolved value of URL when placeholder or SpEL expressions are used to specify value of attribute in element. This decision to create embedded server should be moved elsewhere (may be within org.springframework.security.ldap.DefaultSpringSecurityContextSource?) after attribute values are resolved.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with LdapServerBeanDefinitionParser and org.springframework.security.ldap.DefaultSpringSecurityContextSource, then trace when the ldap-server URL attribute is resolved. The work is done when placeholder or SpEL URL values are resolved before the decision to create an embedded server is made.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100