spring-projects / spring-projects/spring-security
SEC-1959: SavedRequest should give access to the saved request, not only the generated redirect URI
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Piotr Blasiak (Migrated from SEC-1959) said:
The interface for DefaultSavedRequest gives access to fields like scheme, contextPath etc - all that is needed to reconstruct the original request URI and manipulate it safely. The SavedRequest interface, however does not - so a class cast to DefaultSavedRequest is needed to get access to them.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the SavedRequest and DefaultSavedRequest interfaces and locating their implementations in the Spring Security codebase. Determine how the saved request data should be exposed without requiring a cast, then update the relevant tests to verify access to the original request details and the existing redirect behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100