spring-projects / spring-projects/spring-security
RegexRequestMatcher.matches() allocates LogMessage wrapper on every request even when debug disabled
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Describe the bug
web/src/main/java/org/springframework/security/web/util/matcher/RegexRequestMatcher.java:136 allocates memory and wastes CPU when debug logging is disabled - a typical production scenario.
OrRequestMatcher.matches calls every child matcher per request, so this multiplies by the number of regex rules in the security config.
Proposed fix: wrap with isDebugEnabled()
Stacktrace:
org.springframework.core.log.LogMessage$FormatMessage2.<init>(String, Object, Object)
org.springframework.core.log.LogMessage.format(String, Object, Object)
org.springframework.security.web.util.matcher.RegexRequestMatcher.matches(HttpServletRequest)
org.springframework.security.web.util.matcher.OrRequestMatcher.matches(HttpServletRequest)
org.springframework.security.web.DefaultSecurityFilterChain.matches(HttpServletRequest)
org.springframework.security.web.FilterChainProxy.getFilters(HttpServletRequest)
org.springframework.security.web.FilterChainProxy.doFilterInternal(ServletRequest, ServletResponse, FilterChain)
org.springframework.security.web.FilterChainProxy.doFilter(ServletRequest, ServletResponse, FilterChain)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in web/src/main/java/org/springframework/security/web/util/matcher/RegexRequestMatcher.java at line 136 and inspect the logging in matches(). Confirm the LogMessage wrapper is not allocated when debug logging is disabled while request matching remains unchanged, then validate the change with the relevant project tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 74/100