spring-projects / spring-projects/spring-security
Consider catching WebClientException in HaveIBeenPwndApiReactivePasswordChecker
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
HaveIBeenPwnedRestApiPasswordChecker (blocking) catches RestClientException on failure, which covers both HTTP error responses and lower-level I/O errors such as connection timeouts and DNS failures.
The reactive counterpart, HaveIBeenPwnedRestApiReactivePasswordChecker, uses onErrorResume(WebClientResponseException.class, ...). WebClientResponseException only covers HTTP error responses (4xx/5xx).
The semantic equivalent of RestClientException in the reactive stack is WebClientException. It seems more reasonable for the reactive one to use onErrorResume(WebClientException.class, ...) to align with the blocking implementation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating HaveIBeenPwnedRestApiReactivePasswordChecker and its onErrorResume handling, then compare it with the blocking HaveIBeenPwnedRestApiPasswordChecker. Verify that the reactive checker treats WebClientException failures consistently with the blocking implementation, including HTTP errors and lower-level I/O failures.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100