spring-projects / spring-projects/spring-security
Javadoc for HttpSecurity.cors(Customizer<CorsConfigurer<HttpSecurity>>) gives the impression that CORS is opt-in but that's no longer the case
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
The javadoc for HttpSecurity.cors(Customizer<CorsConfigurer<HttpSecurity>>) gives the impression that CORS is opt-in. Since the changes made for #5011 and #15444 that's no longer the case with a single UrlBasedCorsConfigurationSource bean now being sufficient to enable CORS without using the cors portion of the security configuration DSL.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Javadoc for HttpSecurity.cors(Customizer<CorsConfigurer>) and review the behavior introduced by #5011 and #15444. Update the wording so it no longer implies that CORS is enabled only through the security DSL, and verify that the documentation accurately describes a single UrlBasedCorsConfigurationSource bean as sufficient.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- documentation, security
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100