spring-projects / spring-projects/spring-security
`InetAddressMatchers.matchExternal()` matches `null` and `0.0.0.0`
Open
Beginner friendly
Nobody has claimed this yet.
status: waiting-for-triage
type: bug
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Describe the bug
InetAddressMatchers.matchExternal().build() returns a negated matchInternal() builder, however, I'm not sure that null or 0.0.0.0 should be classified as external addresses.
To Reproduce
InetAddressMatcher matcher = InetAddressMatchers.matchExternal().build();
assertThat(matcher.matches(null)).isFalse();
assertThat(matcher.matches("0.0.0.0")).isFalse();
assertThat(matcher.matches("::")).isFalse();
Expected behavior
See above
Sample
See above
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search for the InetAddressMatchers.matchExternal() entry point and inspect how its matcher handles null, 0.0.0.0, and ::. Reproduce the assertions from the issue, then confirm they all return false while existing external-address behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100