spring-projects / spring-projects/spring-security

client_secret_basic authentication failures should return challenge

Open
#18,285 26 comments 3 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

in: oauth2 type: bug
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

As per section 3.2.3.1. Error Response:

"invalid_client": Client authentication failed (e.g., unknown
client, no client authentication included, or unsupported
authentication method). The authorization server MAY return an
HTTP 401 (Unauthorized) status code to indicate which HTTP
authentication schemes are supported. If the client attempted
to authenticate via the "Authorization" request header field,
the authorization server MUST respond with an HTTP 401
(Unauthorized) status code and include the "WWW-Authenticate"
response header field matching the authentication scheme used
by the client.

We should respond with the required authentication scheme when a client fails authentication.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.