spring-projects / spring-projects/spring-security

Extend ClientSettings to support DpOP

Open
#18,228 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

in: oauth2 type: enhancement
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

In general, OAuth2 Clients can be configured with special settings in an OAuth2 Authorization Provider.

One such option is PKCE, which Spring Security supports as a client setting thanks to https://github.com/spring-projects/spring-security/issues/16382.

The ClientSettings object is not extensible, so it's not possible to accomodate for other types of settings. In my case, I would need to mark certain ClientRegistration objects to require DpOP. But it doesn't seem like there's a way to do that with the current APIs.

On top of my head, I would consider extending ClientSettings with a requireDpop field. But I guess there could be other way to extend the registration.

I'm trying to add support for DpOP to Spring Security OAuth2 Client. The rest of the APIs can be easily customized, but not being able to specify whether to use DpOP as part of a ClientRegistration is a major limitation.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining the ClientSettings and ClientRegistration APIs, then compare how the existing PKCE client setting is represented and consumed. Define an extensibility approach that lets a registration indicate DPoP is required without limiting other provider-specific settings; done means the setting can be configured and consumed by the OAuth2 client APIs.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
api, authentication, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.