spring-projects / spring-projects/spring-security
Allow AbstractRestClientOAuth2AccessTokenResponseClient to be extended
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Expected Behavior
AbstractRestClientOAuth2AccessTokenResponseClient can be publicly extended.
Current Behavior
AbstractRestClientOAuth2AccessTokenResponseClient cannot be publicly extended because it has a package-private constructor.
Context
I would like to add support for Requesting Party Tokens using AbstractRestClientOAuth2AccessTokenResponseClient. I am unable to extend this class because it has a package-private constructor. Everything else within this class can be overridden (restClient, headersConverter and parametersConverter). At the moment, I have to copy the code of this class instead of simply configuring my own parametersConverter.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating AbstractRestClientOAuth2AccessTokenResponseClient and inspect its constructor alongside the overridable restClient, headersConverter, and parametersConverter members. Make the class publicly extendable without changing its existing behavior, and verify that custom parameter conversion can be configured for Requesting Party Tokens.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend, security
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100