spring-projects / spring-projects/spring-security
DefaultAuthorizationManagerFactory.Builder FactorGrantedAuthority support
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
We should consider adding FactorGrantedAuthority for DefaultAuthorizationManagerFactory.Builder. A few ideas of the usage below (that need thought out more carefully) are provided below.
An example of using the builder might be:
Builder.requireFactor(RequiredFactor.Builder);
A convenience method might be added for each type
Builder.requirePassword()
Then a method for specifying the duration
Builder.requirePasswordWithin(Duration)
Upon doing so, if it hasn't been released we would probably remove the AllAuthoritiesAuthorizationManager from DefaultAuthorizationManagerFactory.Builder
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with DefaultAuthorizationManagerFactory.Builder and the AllAuthoritiesAuthorizationManager reference in the issue. Work out whether FactorGrantedAuthority support should use a required factor, convenience methods, and duration handling; done means an agreed builder API and a decision about the AllAuthoritiesAuthorizationManager.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authorization, security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100