spring-projects / spring-projects/spring-security
Consider Adding `Authentication.Builder.authentication(Authentication)`
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
CAUTION This is a ticket that needs to be considered by the Spring Security team and thus is not currently a candidate for a pull request.
Currently, there is a lot of duplicated logic for merging two Authentication instances that cannot be replaced (see https://github.com/spring-projects/spring-security/commit/64c9e3e210d60b775ae0bcdea004fc1fc213e1ca for the locations).
We should consider adding Authentication.Builder.authentication(Authentication) which can encapsulate the logic and allow custom Authentication.toBuilder() implementations to replace the way in which the Authentication instances are merged.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the duplicated Authentication-merging locations referenced in commit 64c9e3e210d60b775ae0bcdea004fc1fc213e1ca, then examine the Authentication.Builder and Authentication.toBuilder APIs described in the issue. Done would require a Spring Security team decision on whether the builder method should be added and how custom toBuilder implementations should use it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- authentication, security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100