spring-projects / spring-projects/spring-security
InitializeUserDetailsBeanManagerConfigurer should respect primary flag
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Expected Behavior
If one of multiple UserDetailsService beans is primary, then it should be configured.
Current Behavior
Warning log message instead.
Context
I want to enhance existing UserDetailsService like this:
@Primary
@Bean
public UserDetailsService primaryUserDetailsService(UserDetailsService userDetailsService) {
return (username) -> {
// TODO load user from other source
return userDetailsService.loadUserByUsername(username);
};
}
I'd like to contribute if it's accepted.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeUserDetailsBeanManagerConfigurer.java around lines 86-92 and trace how multiple UserDetailsService beans are handled. Verify the primary bean case, then add coverage showing that a primary UserDetailsService is configured instead of producing the warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100