spring-projects / spring-projects/spring-security

InitializeUserDetailsBeanManagerConfigurer should respect primary flag

Open
#17,902 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

status: waiting-for-triage type: enhancement
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

Expected Behavior
If one of multiple UserDetailsService beans is primary, then it should be configured.

Current Behavior
Warning log message instead.

https://github.com/spring-projects/spring-security/blob/c905ac359dde44cb35bca688444438c2b8fe6beb/config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeUserDetailsBeanManagerConfigurer.java#L86-L92

Context

I want to enhance existing UserDetailsService like this:

    @Primary
    @Bean
    public UserDetailsService primaryUserDetailsService(UserDetailsService userDetailsService) {
        return (username) -> {
            // TODO load user from other source
            return userDetailsService.loadUserByUsername(username);
        };
    }

I'd like to contribute if it's accepted.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeUserDetailsBeanManagerConfigurer.java around lines 86-92 and trace how multiple UserDetailsService beans are handled. Verify the primary bean case, then add coverage showing that a primary UserDetailsService is configured instead of producing the warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.