spring-projects / spring-projects/spring-security
Revisit AuthorizationManager generics and nullability
Open
Nobody has claimed this yet.
status: waiting-for-triage
type: enhancement
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Why can't SessionConcurrencyDslTests have a null value below?
val isAdmin: AuthorizationManager<Any> = AuthorityAuthorizationManager.hasRole("ADMIN")
http {
sessionManagement {
sessionConcurrency {
maximumSessions {
authentication -> if (isAdmin.authorize({ authentication }, "")!!.isGranted) -1 else 1 // why can't "" be changed to null here?
}
maxSessionsPreventsLogin = true
}
}
formLogin { }
}
return http.build()
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with SessionConcurrencyDslTests and trace the AuthorizationManager generic and nullability declarations used by maximumSessions. Determine whether the authorization call should accept null instead of an empty string, and record the expected API behavior with a focused test or other project-approved change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, kotlin
- Domain
- authorization
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100