spring-projects / spring-projects/spring-security
Issue: Custom Saml2LogoutRequestValidatorParametersResolver Implementation Not Picked Up: saml2
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Description
According to the documentation it is possible to customize the Saml2LogoutRequestValidatorParametersResolver for logout requests
"For Logout Requests, customize the Saml2LogoutRequestValidatorParametersResolver"
However, when implementing a custom class that extends Saml2LogoutRequestValidatorParametersResolver, it is not picked up. Instead, the default OpenSamlLogoutRequestValidatorParametersResolver is always used.
Observations
Looking at Saml2LogoutConfigurer, the createLogoutRequestProcessingFilter method explicitly creates an instance of OpenSamlLogoutRequestValidatorParametersResolver. There is no clear way to replace this with a custom implementation.
It would be helpful if the documentation provided an example or guidance on how to properly configure and register a custom Saml2LogoutRequestValidatorParametersResolver.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Saml2LogoutConfigurer and its createLogoutRequestProcessingFilter method, then inspect Saml2LogoutRequestValidatorParametersResolver and OpenSamlLogoutRequestValidatorParametersResolver. Determine whether a custom resolver can be registered through the documented configuration; done means the supported customization path works or the documentation clearly explains the limitation and configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100