spring-projects / spring-projects/spring-security

DelegatingPasswordEncoder should provide additional argument to specify the encode algorithm

Open
#16,827 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

status: waiting-for-triage type: enhancement
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

Currently, in DelegatingPasswordEncoder class

@Override
public String encode(CharSequence rawPassword) {
	return this.idPrefix + this.idForEncode + this.idSuffix + this.passwordEncoderForEncode.encode(rawPassword);
}

Enhancement: Add an overload method

@Override
public String encode(CharSequence rawPassword, String idForEncode) {
	return this.idPrefix + idForEncode + this.idSuffix + this.idToPasswordEncoder.get(idForEncode ).encode(rawPassword);
}

With this enhancement, we can now easily choose a different encoder when encoding a plain password.
This allows us to create the DelegatingPasswordEncoder using the simple api call PasswordEncoderFactories.createDelegatingPasswordEncoder() and yet able to use the created encoder to switch between different encoding algorithms whenever encoding is performed

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with DelegatingPasswordEncoder and the PasswordEncoderFactories.createDelegatingPasswordEncoder() entry point, then trace the existing PasswordEncoder API and related tests. Confirm how an explicitly selected encoder should be chosen and how invalid identifiers are handled. Done means the requested overload can select a configured encoding algorithm without breaking the existing API, with tests covering the resulting encoded identifier and value.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.