spring-projects / spring-projects/spring-security
Replace WebInvocationPrivilegeEvaluator
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
With the introduction of AuthorizationManager, it should be possible to deprecate WebInvocationPrivilegeEvaluator.
The steps are as follows:
- Expose an Authorization Manager that can accept request elements
- Update JSP taglib support to use AuthorizationManager
- Deprecate WebInvocationPrivilegeEvaluator and implementations
Note that the default WebInvocationPrivilegeEvaluator implementation also allows for setting a HttpServletRequestTransformer; however this need not be ported as it exists largely to facilitate coordination with HandlerMappingIntrospector, which is also being deprecated.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing AuthorizationManager support for request elements and tracing JSP taglib support that currently uses WebInvocationPrivilegeEvaluator. Confirm how the default evaluator and its HttpServletRequestTransformer relate to the deprecated HandlerMappingIntrospector. Done means request elements are supported, JSP taglibs use AuthorizationManager, and WebInvocationPrivilegeEvaluator implementations are deprecated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- authorization
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100