spring-projects / spring-projects/spring-security
Improve the BasicAuthenticationFilter to allow callbacks for both successful and failed authentication events.
@jzheaux is already working on this.
Since Dec 16, 2024.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Expected Behavior
Can customize and set callback method in BasicAuthenticationFilter. (Such as logging, saving audit log .. etc)
Current Behavior
Now, there are two empty protected method called onSuccessFulAuthentication, onUnsuccessfulAuthentication.
I think it would be nice if I can customize the actions of these methods.
Context
I use Basic authentication for authentication in server-to-server communication within an private internal network.
And I wish I could save the information of client for audit log. (Which client call which api how many times during specific period)
For this reason, I looked into this BasicAuthenticaionFilter and I found those two empty methods.
So I wanna improve BasicAuthenticationFilter If youguys are ok with it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.