spring-projects / spring-projects/spring-security
Consider adding `ClientRegistrationIdResolver` to `ExchangeFilterFunction`s
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
We should align (Server|Servlet)OAuth2AuthorizedClientExchangeFilterFunction with OAuth2ClientHttpRequestInterceptor which introduces a ClientRegistrationIdResolver as a flexible strategy for resolving the clientRegistrationId for a given request. For WebClient-based ExchangeFilterFunctions, the interface could be:
@FunctionalInterface
public interface ClientRegistrationIdResolver {
@Nullable
String resolve(ClientRequest request);
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading OAuth2ClientHttpRequestInterceptor and the ServerOAuth2AuthorizedClientExchangeFilterFunction and ServletOAuth2AuthorizedClientExchangeFilterFunction references in the issue. Compare how each resolves clientRegistrationId and determine the scope of a shared ClientRegistrationIdResolver for WebClient ExchangeFilterFunctions. Done means the proposed alignment is implemented consistently and its behavior is verified for both filter functions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend-api-design, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100