spring-projects / spring-projects/spring-security

Consider removing one level of the OIDC Backchannel Logout DSL

Open
#15,817 2 comments 0 reactions 1 assignee View on GitHub

@alswp006 is already working on this.

Since Oct 28, 2024.

in: oauth2 type: enhancement
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

To active OIDC Back-Channel Logout support in the DSL, an application does this:

http
    .oidcLogout((oidc) -> oidc.backChannel(Customizer.withDefaults())
    )

This could be simplified to:

http
   .oidcBackChannelLogout(Customizer.withDefaults())

This would be place the logout DSL at the same level as other logout DSLs:

http
    .logout((logout) -> logout ...)
    .saml2Logout((saml2) -> saml2 ...
    .oidcBackChannelLogout((oidc) -> oidc ...)

Also, it's less nesting which often makes the DSL more navigable.

This would mean deprecating the existing backChannel DSL method with the intent to remove in the next major version.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.