spring-projects / spring-projects/spring-security
Updating to mockito 4.11.0 causes OAuth2LoginBeanDefinitionParserTests and OAuth2ClientBeanDefinitionParserTests to fail
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
In some way, mocking the OAuth2AuthorizedClientRepository and publishing it as a bean causes Spring MVC's RequestMappingHandlerAdapter bean to be constructed before the OAuth2AuthorizedClientArgumentResolver can be registered.
Changing the corresponding tests to use HttpSessionOAuth2AuthorizedClientRepository addressed the issue so that the upgrade could happen, though this should still be investigated to find the root cause.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running OAuth2LoginBeanDefinitionParserTests and OAuth2ClientBeanDefinitionParserTests with Mockito 4.11.0 and compare them with the HttpSessionOAuth2AuthorizedClientRepository workaround. Trace when RequestMappingHandlerAdapter is constructed relative to OAuth2AuthorizedClientArgumentResolver registration. Done means identifying the root cause and confirming a focused test change or fix resolves both failures.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, spring
- Domain
- backend, security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100