spring-projects / spring-projects/spring-security

Deprecate PortResolver

Open
#12,971 0 comments 2 reactions 1 assignee View on GitHub

@rwinch is already working on this.

Since Feb 26, 2025.

type: task
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

PortResolver was created to work around an old IE bug where ServerRequest.getServerPort() could return the incorrect port at times. We should:

  • #16664
  • #7273
  • Construct Absolute URLs used with communicating with an IdP (i.e. CAS, SAML, OAuth, etc) without the PortMapper
  • #15972
  • #16666

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.