spring-projects / spring-projects/spring-security
Saml2LogoutRequest constructor should check for null values
Open
Nobody has claimed this yet.
in: saml2
type: breaks-passivity
type: enhancement
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
Inspired by #12539
The constructor in Saml2LogoutRequest does not check if the parameters received are not null
Expected behavior:
The constructor should use Assert.notNull and related to check if the parameters are valid
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Saml2LogoutRequest constructor and compare its parameter handling with the approach referenced in issue #12539. Add null validation using Assert.notNull or related checks for each constructor parameter; done means invalid values are rejected consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100