spring-projects / spring-projects/spring-security

Document what happens when DSL is invoked twice

Open
#12,627 0 comments 0 reactions 1 assignee View on GitHub

@rwinch is already working on this.

Since Feb 3, 2023.

in: docs type: enhancement
Dominant language
Java
Stars
9.6k
Forks
6.3k
Avg merge
2d 11h
Merged PRs (30d)
52

Description

We should document in Javadoc and the reference what happens if the DSL is invoked twice. For example, what happens if the following is done:

http.authorizeHttpRequests(request -> request.anyRequest().permitAll());

http.authorizeHttpRequests(request -> request.anyRequest().denyAll())

Does this override values or does it add to them? There are other configurations where values are set vs added that would be interesting to explicitly document. For example

http.csrf().csrfTokenRepository(first); // ...
http.csrf().csrfTokenRepository(second); // ...

We should also document lambdas

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.