spring-projects / spring-projects/spring-security
Document what happens when DSL is invoked twice
Open
@rwinch is already working on this.
Since Feb 3, 2023.
in: docs
type: enhancement
- Dominant language
- Java
- Stars
- 9.6k
- Forks
- 6.3k
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 52
Description
We should document in Javadoc and the reference what happens if the DSL is invoked twice. For example, what happens if the following is done:
http.authorizeHttpRequests(request -> request.anyRequest().permitAll());
http.authorizeHttpRequests(request -> request.anyRequest().denyAll())
Does this override values or does it add to them? There are other configurations where values are set vs added that would be interesting to explicitly document. For example
http.csrf().csrfTokenRepository(first); // ...
http.csrf().csrfTokenRepository(second); // ...
We should also document lambdas
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.